Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify application group rounded corners #285

Merged
merged 1 commit into from
May 23, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented May 22, 2024

Modify the rounded corners of windowed to 20

Issue: linuxdeepin/developer-center#8336

Modify the rounded corners of windowed to 20

Issue: linuxdeepin/developer-center#8336
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FolderGridViewPopup.qml文件中,titleMargin属性的添加可能会影响其他组件或布局的的行为,需要确认是否有其他代码依赖于这个属性。
  • 修改了TextInputText组件的leftMarginrightMargin,使用了contentRoot.titleMargin来计算边距,需要确保contentRoot对象和titleMargin属性在使用前已经正确初始化。

是否建议立即修改:

  • 是,需要确保titleMargin属性的添加不会导致布局问题,并且所有相关的依赖都已经正确实现。同时,应该验证contentRoot对象和titleMargin属性的初始化是否充分。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented May 23, 2024

/merge

@deepin-bot deepin-bot bot merged commit ffbf93b into linuxdeepin:master May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants