Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: now require AppStreamQt 1.0 #284

Merged
merged 1 commit into from
May 21, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented May 17, 2024

之前由于仓库尚不存在 1.x 版本的 AppStream 软件包,所以尽管 debian 依赖写了对 appstreamqt 的依赖,但实际对应的支持是不会被启用的。现 AppStream 1.0.3 已进入 deepin 仓库,故开始强制要求 AppStream 依赖 存在。

#281 有一定相关性(原为 AppStream 配置 不存在时提供的后备方案)。

之前由于仓库尚不存在 1.x 版本的 AppStream 软件包,所以尽管 debian
依赖写了对 appstreamqt 的依赖,但实际对应的支持是不会被启用的。现
AppStream 1.0.3 已进入 deepin 仓库,故开始强制要求 AppStream 依赖
存在。

与 linuxdeepin#281 有一定相关性(原为 AppStream 配置
不存在时提供的后备方案)。

Log:
@BLumia BLumia requested a review from a team May 17, 2024 07:13
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在CMakeLists.txt中,find_package指令的版本指定应该保持一致性,建议在所有使用的地方都使用REQUIRED选项。
  • 在debian/control文件中,libappstreamqt-dev的版本指定更新为>= 1.0.0,确保与项目的版本控制策略一致。
  • 移除了#ifndef NO_APPSTREAM_QT宏定义,如果其他文件依赖于这个宏定义,可能会导致编译错误。
  • 删除了与dde-integration-dbus目标相关的链接库选项,需要确认这是否是故意为之,以及是否会影响依赖关系。

是否建议立即修改:

  • 是,需要确保版本控制的一致性和编译选项的正确性,以及避免潜在的依赖问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
Copy link
Member Author

BLumia commented May 21, 2024

/merge

@deepin-bot deepin-bot bot merged commit 085b300 into linuxdeepin:master May 21, 2024
10 checks passed
@BLumia BLumia deleted the appstream-1.x branch May 21, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants