Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure AppItemMenu is modal #274

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented May 10, 2024

Likely a DTK issue but anyway...

Issue: linuxdeepin/developer-center#8477

Likely a DTK issue but anyway...

Issue: linuxdeepin/developer-center#8477
Log:
@BLumia BLumia requested a review from a team May 10, 2024 02:22
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AppItemMenu.qml文件中,Menu组件新增了modal属性,这可能会影响用户界面的显示逻辑。需要确认这一改动是否符合设计要求。

是否建议立即修改:

  • 是,如果modal属性的改动是无意的或者不符合设计要求,应立即进行修正。同时,需要确保这一改动不会与现有功能和用户界面的其他部分产生冲突。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit d644129 into linuxdeepin:master May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants