Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow continue search when SearchEdit isn't focused #261

Merged
merged 1 commit into from
May 8, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented May 8, 2024

全屏启动器行为调整,搜索框无焦点时均允许按下字母键继续搜索,按下的键会追加到搜索框内。

(其实搜索内容为空时也可以是直接往后追加,这里避免后续有别的奇怪需求,暂且分成 if else 来写)

Issue: linuxdeepin/developer-center#7627

全屏启动器行为调整,搜索框无焦点时均允许按下字母键继续搜索,按下的键
会追加到搜索框内。

Issue: linuxdeepin/developer-center#7627
Log:
@BLumia BLumia requested a review from a team May 8, 2024 06:03
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码逻辑中移除了对searchEdit.text是否为空的检查,可能会导致在searchEdit.text为空时重复添加event.text
  • searchEdit.focus的检查被移除,这意味着在baseLayer.focus为真时,无论searchEdit.focus如何都会执行switch语句。

是否建议立即修改:

建议的修改:

  • 在执行searchEdit.text += event.text之前,应该检查searchEdit.text是否为空,以避免在searchEdit.text为空时重复添加文本。
  • 需要恢复对searchEdit.focus的检查,以确保在baseLayer.focus为真时,只有当searchEdit.focus为真时才会执行switch语句。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit d09ee75 into linuxdeepin:master May 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants