Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The size of the rounded corners in the small window folder is incorrect #248

Merged
merged 1 commit into from
May 6, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented May 6, 2024

Adjust the rounded corners of the small window folder and the item background color

Issue: linuxdeepin/developer-center#8338

…correct

Adjust the rounded corners of the small window folder and the item background color

Issue: linuxdeepin/developer-center#8338
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • IconItemDelegate.qml中,导入模块的别名DDS可能会引起混淆,建议使用完整的包名以提高代码的可读性。
  • 新增的background属性使用了Qt.rgba来创建颜色,建议使用预定义的常量以提高代码的可维护性。
  • color1color2属性的计算逻辑可能需要优化,以避免在每次渲染时都要进行isWindowedMode的判断。

是否建议立即修改:

@mhduiy mhduiy changed the title fix: The size of the rounded corners in the small window folder is in… fix: The size of the rounded corners in the small window folder is incorrect May 6, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 99e527a into linuxdeepin:master May 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants