Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swipe and drag conflicts #241

Merged
merged 2 commits into from
Apr 28, 2024
Merged

fix: swipe and drag conflicts #241

merged 2 commits into from
Apr 28, 2024

Conversation

asterwyx
Copy link
Contributor

  • Revert the previous fix.
  • Fix with a different policy.

Place DragHandler in iconLoader, only trigger drag when press icon.

Log: fix swipe and drag conflicts
@asterwyx asterwyx requested a review from BLumia April 28, 2024 06:46
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码重构导致了一些功能(如拖放、长按处理等)从IconItemDelegate移动到了FullscreenFrame,可能需要确认这是否是预期的功能变更。
  • TapHandlerDragHandler的引入替代了原有的TimerTapHandler,这有助于提高代码的可读性和可维护性。
  • TapHandler中,移除了对Timer的使用,改为直接在DragHandler中处理拖放事件,这可能影响性能,需要评估是否有必要。

是否建议立即修改:

  • 是,需要确认功能变更是否符合预期,并确保代码的性能和安全性没有降低。如果Timer的移除会导致性能问题,应该考虑恢复或替换原有的逻辑。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit df8b435 into linuxdeepin:master Apr 28, 2024
9 of 10 checks passed
@asterwyx asterwyx deleted the dnd branch May 8, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants