Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: add support for configuring the VPC interface #518

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

eljohnson92
Copy link
Collaborator

@eljohnson92 eljohnson92 commented Sep 18, 2024

What this PR does / why we need it:
This PR supports customizing the VPC interface with 1:1 NAT or public interface settings through providing an explicit VPC interface on the LinodeMachine such as

---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
kind: LinodeMachineTemplate
metadata:
  name: test-cluster-md-0
  namespace: default
spec:
  template:
    spec:
      image: linode/ubuntu22.04
      interfaces:
      - purpose: vpc
        primary: false
      - purpose: public
        primary: true
    

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (708b0ac) to head (d511370).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   65.08%   65.55%   +0.46%     
==========================================
  Files          77       77              
  Lines        3990     4003      +13     
==========================================
+ Hits         2597     2624      +27     
+ Misses       1163     1143      -20     
- Partials      230      236       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait
Copy link
Contributor

The change looks good to me. Should we also add some documentation related to it just in case someone else is interested in using such settings?

rahulait
rahulait previously approved these changes Sep 19, 2024
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eljohnson92 eljohnson92 merged commit 17568b5 into main Sep 19, 2024
13 checks passed
@eljohnson92 eljohnson92 deleted the vpc_interface_config branch September 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants