Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add placement group docs and update firewall docs #504

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
This PR adds docs for the placement group feature and update firewall docs to include our current flavor integration
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
komer3
komer3 previously approved these changes Sep 6, 2024
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AshleyDumaine
AshleyDumaine previously approved these changes Sep 6, 2024
@eljohnson92 eljohnson92 merged commit a6ff16b into main Sep 6, 2024
10 checks passed
@eljohnson92 eljohnson92 deleted the add_placement_docs branch September 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants