Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] added placementGroup to full flavors #499

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

prajwalvathreya
Copy link
Contributor

What this PR does / why we need it: This PR adds the placement groups to full flavors by default when a cluster is created

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (3a88aed) to head (91018ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files          77       77           
  Lines        3982     3982           
=======================================
  Hits         2585     2585           
  Misses       1166     1166           
  Partials      231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prajwalvathreya prajwalvathreya merged commit ca72308 into main Sep 5, 2024
18 checks passed
@eljohnson92 eljohnson92 deleted the add-placementgroups branch September 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants