Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add v1alpha2 of linodeMachineTemplate #428

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
This PR adds version v1alpha2 of the linodeMachineTemplate resource
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (a417bbc) to head (32d64dd).

Files Patch % Lines
api/v1alpha1/linodemachinetemplate_conversion.go 27.58% 16 Missing and 5 partials ⚠️
api/v1alpha2/linodemachinetemplate_webhook.go 0.00% 4 Missing ⚠️
cmd/main.go 0.00% 3 Missing ⚠️
api/v1alpha2/linodemachinetemplate_conversion.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   68.08%   67.57%   -0.51%     
==========================================
  Files          60       64       +4     
  Lines        3393     3433      +40     
==========================================
+ Hits         2310     2320      +10     
- Misses        946      971      +25     
- Partials      137      142       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 merged commit 020790d into main Jul 26, 2024
20 of 22 checks passed
@AshleyDumaine AshleyDumaine deleted the linodemachinetemplate_update branch August 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants