Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix create/update opertions if leftover DNS entries are found #424

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Jul 24, 2024

What this PR does / why we need it:
Currently if an old un-removed DNS A Record is found that matches the name and IP exactly, we look for a TXT record to determine ownership. If TXT record was somehow cleaned in the previous run, controller errors out.
With this fix, if the exact DNS record is found, we leave it alone and push a new TXT record for future updates and deletes.

(This situation arises when we create the cluster with the same name and dns unique id. If the dns record deletion failed on cluster removal, you would see this bug. The IP matches because linode keeps/caches some IPs for the account so you might end up with the same IP being re-assigned)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@amold1 amold1 self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (a417bbc) to head (fab635e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   68.08%   68.02%   -0.07%     
==========================================
  Files          60       60              
  Lines        3393     3374      -19     
==========================================
- Hits         2310     2295      -15     
+ Misses        946      944       -2     
+ Partials      137      135       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eljohnson92
eljohnson92 previously approved these changes Jul 25, 2024
eljohnson92
eljohnson92 previously approved these changes Jul 25, 2024
@amold1 amold1 merged commit a343c76 into main Jul 26, 2024
11 of 12 checks passed
@amold1 amold1 deleted the linodedns.updates.bug branch August 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants