Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old-version banner not linking to latest page #1809

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

travisbeckham
Copy link
Collaborator

@travisbeckham travisbeckham commented Jul 31, 2024

This PR fixes the link in the old-version banner so it links to the corresponding latest page.

Testing:
Section page → https://deploy-preview-1809--linkerdio.netlify.app/2.14/features/
Regular page → https://deploy-preview-1809--linkerdio.netlify.app/2.14/features/ingress/

Fixes #1802

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have grown to loathe .page.Path and .page.File. 😂 Yeah, hit it -- thanks!! 👍

@travisbeckham travisbeckham merged commit c33f9fd into main Aug 1, 2024
7 checks passed
@travisbeckham travisbeckham deleted the travis/old-version-banner branch August 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge docs incorrectly state that the corresponding stable docs don't exist
2 participants