Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds helm chart to app version matrix #1714

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Conversation

logicminds
Copy link
Contributor

@logicminds logicminds commented Nov 21, 2023

Previously, there was not an easy way to correlate the app version to a helm chart version. Many people ask this question in public slack channel or must get data themselves. This adds a script to produce the desired matrix data as a table, json, or yaml output to help folks who are upgrading. Without this matrix the versions are very confusing. A python script is provided to generate the necessary data.

This also adds a new make target to produce the content build-release-matrix. I prepended the target call to the build-linkerd.io target so that upon creation the data would be generated.

Screenshot 2023-11-27 at 9 34 34 PM

@kflynn
Copy link
Member

kflynn commented Dec 1, 2023

@logicminds Hmmm, the Python script actually doesn't seem to be present in this PR? 🙂

@logicminds
Copy link
Contributor Author

logicminds commented Dec 1, 2023

@logicminds Hmmm, the Python script actually doesn't seem to be present in this PR? 🙂

ahh. The bin directory was ignored which prevented the script from being added. I have fixed this but wondering why bin was ignored in the first place.

@kflynn
Copy link
Member

kflynn commented Dec 5, 2023

Wow, that looks more painful than I thought. Thanks!! If you can fix the linter errors, I'll see about getting this landed -- appreciate it!

@logicminds
Copy link
Contributor Author

@kflynn please run the checks as I am unable to do so

  * Previously, there was not an easy way to correlate the app version
    to a helm chart version.  Many people ask this question in public
    slack channel or must get data themselves.  This adds a script
    to produce the desired matrix data as a table, json, or yaml output
    to help folks who are upgrading.

Signed-off-by: Corey Osman <[email protected]>
  * Previously the bin directory was being ignored despite this being
    a logical place to contain scripts.  It has been re-enabled
    and the python script was added as a result.

  * Update script to handle edge releases better

Signed-off-by: Corey Osman <[email protected]>
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this landed. 🙂 Many thanks for sticking with this, @logicminds! I'll likely do some tweaks to the way this fits into the build process, but having this as a base will be a big win.

@kflynn kflynn merged commit feddd13 into linkerd:main Jan 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants