Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links on home page #1682

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fixed links on home page #1682

merged 2 commits into from
Sep 18, 2023

Conversation

travisbeckham
Copy link
Collaborator

Linked buoyant logo in the company list, and opened cased studies in a new tab.

@@ -3,7 +3,7 @@
<div class="column is-narrow created-by mr-4">
<p class="is-size-6 mb-4">Linkerd was created by</p>
<figure class="image">
<img src="/uploads/buoyant-logo-blue.png" alt="Buoyant" />
<a href="https://buoyant.io/" target="_blank"><img src="/uploads/buoyant-logo-blue.png" alt="Buoyant" /></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work to extend the <a> all the way to cover the "Linkerd was created by" text too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bet. The change has been pushed.

Signed-off-by: Travis Beckham <[email protected]>
@travisbeckham travisbeckham merged commit 0bdfd26 into main Sep 18, 2023
8 checks passed
@travisbeckham travisbeckham deleted the travis/fix-links branch September 18, 2023 17:04
yohanb pushed a commit to yohanb/linkerd-website that referenced this pull request Sep 21, 2023
* linked buoyant in logo list and opened cased studies in a new tab

---------

Signed-off-by: Travis Beckham <[email protected]>
yohanb pushed a commit to yohanb/linkerd-website that referenced this pull request Sep 21, 2023
* linked buoyant in logo list and opened cased studies in a new tab

---------

Signed-off-by: Travis Beckham <[email protected]>
Signed-off-by: Yohan Belval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants