Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document HTTPRoute timeouts #1662

Merged
merged 12 commits into from
Aug 21, 2023
Merged

document HTTPRoute timeouts #1662

merged 12 commits into from
Aug 21, 2023

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Aug 21, 2023

This branch adds new documentation for the HTTPRoute timeout fields
added in Linkerd 2.14. This includes adding the HTTPRoute timeout fields
to the HTTPRoute reference docs, and adding a section on using HTTPRoute
timeouts to the "Configuring Timeouts" tasks doc.

@hawkw hawkw self-assigned this Aug 21, 2023
kflynn
kflynn requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor nit and a question about parsing. Thanks!! 🙂

linkerd.io/content/2-edge/tasks/configuring-timeouts.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/httproute.md Outdated Show resolved Hide resolved
@hawkw hawkw mentioned this pull request Aug 21, 2023
Merged
kflynn
kflynn requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I just noticed one more nit. New syntax language looks great. 🙂

linkerd.io/content/2-edge/reference/httproute.md Outdated Show resolved Hide resolved
@hawkw hawkw requested a review from kflynn August 21, 2023 18:47
kflynn
kflynn approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording nit but looks good! Approving whether that gets fixed or not. 🙂

linkerd.io/content/2-edge/reference/httproute.md Outdated Show resolved Hide resolved
kflynn
kflynn approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit it!! 🙂

wmorgan
wmorgan approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@wmorgan wmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hawkw hawkw merged commit ff64269 into main Aug 21, 2023
7 checks passed
@hawkw hawkw deleted the eliza/timeout-docs branch August 21, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmorgan wmorgan wmorgan approved these changes

@kflynn kflynn kflynn approved these changes

@adleong adleong Awaiting requested review from adleong

Assignees

@hawkw hawkw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkw @wmorgan @kflynn