Add missing linkerd.io/control-plane-ns label
#12742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ext-namespace-metadata-linkerd-config` Role is the only resource in the base Linkerd install that doesn't include the `linkerd.io/control-plane-ns` label, and that appears to be an oversight. This change adds the missing label for consistency. Signed-off-by: Kevin Ingelman <[email protected]>
olix0r
approved these changes
Jun 18, 2024
alpeb
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ext-namespace-metadata-linkerd-configRole is the only resource in the Linkerd control plane install that doesn't include thelinkerd.io/control-plane-nslabel, and that appears to be an oversight.This change adds the missing label for consistency.
Fixes #12271
Signed-off-by: Kevin Ingelman [email protected]