-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hearthbeat cj prometheus url hardcoded #9357
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
I stumbled across this as well.
The only solution is to disable the heartbeat job. Shouldn't be to hard to make the url configurable (e.g. by a value Just ignoring this does not feel right. But being new to Linkerd maybe I am wrong |
Hi, could I take this issue? |
Hey, could i take up this issue? |
This issue has been fixed by #11343, and can be closed |
What is the issue?
Using own prometheus instance, especially in different namespace - hearthbeat fails due to hardcoded url in helm chart -
https://github.com/linkerd/linkerd2/blob/main/charts/linkerd-control-plane/templates/heartbeat.yaml#L63
How can it be reproduced?
Follow "Bring your own prometheus" guide and run hearthbeat cj
Logs, error output, etc
N/
output of
linkerd check -o short
Environment
All
Possible solution
Allow to pass prometheus url as a variable
Additional context
No response
Would you like to work on fixing this bug?
maybe
The text was updated successfully, but these errors were encountered: