Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry exporter implementation #3215

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

sfleen
Copy link
Collaborator

@sfleen sfleen commented Sep 19, 2024

This mirrors and duplicates most of the logic from the existing OpenCensus exporter to keep the functionality as similar as possible. Setting up the proxy to use this exporter will come in a follow-up.

#10111

@sfleen sfleen force-pushed the otel-export branch 2 times, most recently from 4dd86c1 to e2d2ced Compare September 23, 2024 14:02
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (96124bc) to head (f143524).
Report is 455 commits behind head on main.

Files with missing lines Patch % Lines
linkerd/opentelemetry/src/lib.rs 0.00% 66 Missing ⚠️
linkerd/opentelemetry/src/metrics.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3215      +/-   ##
==========================================
+ Coverage   67.68%   67.91%   +0.23%     
==========================================
  Files         332      362      +30     
  Lines       15158    16854    +1696     
==========================================
+ Hits        10259    11447    +1188     
- Misses       4899     5407     +508     
Files with missing lines Coverage Δ
linkerd/opentelemetry/src/metrics.rs 0.00% <0.00%> (ø)
linkerd/opentelemetry/src/lib.rs 0.00% <0.00%> (ø)

... and 44 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ca37e...f143524. Read the comment docs.

This duplicates most of the logic from the existing OpenCensus exporter to keep the functionality as similar as possible.

[#10111](linkerd/linkerd2#10111)

Signed-off-by: Scott Fleener <[email protected]>
@sfleen sfleen requested a review from olix0r September 23, 2024 19:50
@sfleen sfleen marked this pull request as ready for review September 23, 2024 19:50
@sfleen sfleen requested a review from a team as a code owner September 23, 2024 19:50
@sfleen sfleen merged commit a1d3c79 into linkerd:main Sep 23, 2024
16 of 17 checks passed
@sfleen sfleen deleted the otel-export branch September 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants