Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor OpenTelemetry protocol #3214

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Vendor OpenTelemetry protocol #3214

merged 1 commit into from
Sep 23, 2024

Conversation

sfleen
Copy link
Collaborator

@sfleen sfleen commented Sep 19, 2024

In preparation for supporting the OpenTelemetry protocol for the proxy's traces, this vendors the relevant protobufs as well as some convenience helpers here.

This works around the fact that the existing open-telemetry crate does not support the version of tonic that we currently use (0.10), and this vendoring can be removed once we update.

#10111

In preparation for supporting the OpenTelemetry protocol for the proxy's traces, this vendors the relevant protobufs as well as some convenience helpers here.

This works around the fact that the existing `opentelemetry` crates do not support the version of tonic that we currently use (0.10), and this vendoring can be removed once we update.

[#10111](linkerd/linkerd2#10111)

Signed-off-by: Scott Fleener <[email protected]>
@sfleen sfleen marked this pull request as ready for review September 23, 2024 13:57
@sfleen sfleen requested a review from a team as a code owner September 23, 2024 13:57
@sfleen sfleen requested a review from olix0r September 23, 2024 13:57
Copy link
Collaborator

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

nice!

@sfleen sfleen merged commit 38ca37e into linkerd:main Sep 23, 2024
16 checks passed
@sfleen sfleen deleted the otel-vendor branch September 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants