-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: 'NoneType' object is not iterable #6
Comments
Heya, thanks for the report. When you say:
Do you mean all entries in Please attach your |
Hello! Thanks for the reply! Here's the
I even tried one of your examples just to see if it would get past it in case there was a hard-to-find error in my yaml code.
I've looked through the |
Right, understood. You should only need that one
Looks clean to me.
Good thinking. That helps!
The env vars vary based on what phase the backup is in (and hence what the As you've specified no config for the Can you paste the output of running grapple only with The JOB-INIT:
script: None Can you also paste the I'm wondering if this isn't a Python version issue, or a breaking change from something that grapple depends on. Thanks heaps for helping out! |
It's a pleasure to help. I'm just hoping it's not something stupid I've overlooked. I'm pretty bloody good at Linux, Bash and python et al but even we tech people miss the obvious sometimes because we're looking too deeply! :) Here's the grapple dump;
pipx list;
Here's something.....unexpected....Do I have the commandline wrong or is my penv screwed.
|
Agreed. And you're from Sydney 😉
Yeah, this is odd. There should be some config there, which means your config file wasn't loaded/found. Is the config file you have located as per here? Dynaconf is a little odd in that it assumes missing config files are perfectly ok, and I have an issue logged for it that isn't resolved yet.
All good here.
Yeah, your command is a bit wrong...
So, something like |
I am indeed from Syd! :) Here's the pip listing....Tsk! :)
Is that of any earth-shattering use? |
Looks all good too... sorry, can you answer the other stuff I tucked into the previous reply around config files? |
Sorry, sorry, sorry.... Missed that. Interestingly, in my initial testing, I renamed the file to test if it was finding it and the continued merrily along with the same error message - so when you said that you had an open-issue, that makes perfect sense. |
How about this;
|
Much! The Oh, and with that change, does it now run? |
Do I have to tell you? :( I may have left the file renamed by accident during testing when I ran that dump before. |
lol, right, that unhurts my brain a bit because I just replicated what you're seeing, have a few ideas, and that would have borked everything 🤣 So, a few issues here -- the On using your first initial config both on a 1.5.4 and 1.5.5 install, I see it work fine on 1.5.4, but not 1.5.5. Doing some testing and comparisons to code and 3rd party differences now. |
Ahhh....well at least we're getting somewhere! sorry about that earlier. As I said, this is what happens when I do things in the wee-small hours and forget to put them back... :) |
Nah nah, all good! My turn to be embarrassed -- I broke it in 1.5.5... and it has revealed my unit tests didn't catch the breakage too. Will fix tomorrow. If urgent, or just for fun, downgrade to 1.5.4 and it should work fine: host ~ $ pipx uninstall proxmox-grapple
uninstalled proxmox-grapple! ✨ 🌟 ✨
host ~ $ pipx install proxmox-grapple==1.5.4
installed package proxmox-grapple 1.5.4, installed using Python 3.11.2
These apps are now globally available
- proxmox-grapple
- vzdump-hook-script |
Not urgent at all. Just happy to help out. If it helps for tomorrow, (and I have no idea WHY) but if I send a:
However...
and the job-init still yields our old favourite, the original error. Just a FYI! |
Just for reference, downgrading broke the backup-start:
Anyway...Absolutely no rush. In your own time. As I said, It's in no way urgent. |
Right, this has prompted me to do a bit of a rewrite; I didn't foresee the person in #2 wanting two different run modes, and then I implemented them in the way I did (lazily and badly). So this means a breaking change update, will be pushing that out soon. It should fix all things in this issue, and will now dump config after it is parsed. |
… file format/schema has been updated, and so deployed config files will need to be updated, as per the README.
Done and released as 2.0.0, give it a whirl and let me know, thanks 😄
Also, love this! Big fan of home automation, and Home Assistant myself 😁 |
I see you got a lot of feedback and thanks in #2 as well! :) Will give the new version a spin in a minute. |
Ooh err.... I think I broke it...
Let me investigate... |
Ok. Did some more testing under previous commits , It works in 1.5.4 if I remove the quotes from my curl statement and just leave:
However, it gives the .mode error in v2.00 (Bugger!) |
Hrm, ok... Attach new config, and a dump please? |
Config:
Dump didn't go well... (unlike the one I had earlier...Ahem)
|
Ah, right... And you're on 2.0.0? If so, see the README 😉 You need to update your config, version 2 brings a breaking API/config format change. |
Oh crap, sorry. Even think about RTFM! :) |
Amazing what happens when you think like an end-user instead of a dev. |
Lovely! Good to hear. Thanks heaps for helping out here, appreciate it I might just leave this open a few days. |
Not a problem. Glad to help out. If you want any more testing in the future, I will leave it on my development server so I can play around/test things without fear or recrimination! :) Just let me know. |
G'day,
Got the following error when I tried run a backup with Grapple.
Unfortunately, it's quite a generic error message and I've no idea where to start.
It seems that the HOOK-ENV ought to have something it in and not just None
Could someone point me in the right direction please?
I'm using the following line in /etc/vzdump.conf;
All other entries were commented out...I didn't touch them because it wasn't clear if I should.
Error is:
I'd be grateful for any help.
Cheers!
The text was updated successfully, but these errors were encountered: