xilem_web: Allow DomFragment instead of DomView as app_logic
#482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp-M
force-pushed
the
xilem_web-root-dom-fragment
branch
from
b3393b8
to
5e8a32b
Compare
Philipp-M
commented
Aug 5, 2024
|
|
||
| pub(crate) struct AppMessage { | ||
| pub id_path: Rc<[ViewId]>, | ||
| pub body: DynMessage, | ||
| } | ||
|
|
||
| /// The type responsible for running your app. | ||
| pub struct App<T, V: DomView<T>, F: FnMut(&mut T) -> V>(Rc<RefCell<AppInner<T, V, F>>>); | ||
| pub struct App<State, Fragment: DomFragment<State>, InitFragment>( |
There was a problem hiding this comment.
I'm not sure about the name InitFragment for the app_logic, I'm open for other suggestions, it's also related to this
|
This coincidentally also reduces a little bit of wasm bloat btw. :) |
DJMcNab
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #461. This allows a
ViewSequence(calledDomFragment) ofDomViews as root component.The
counterexample is updated to show this new behavior.