Update Skrifa to 0.22.0 #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrg
approved these changes
Sep 23, 2024
vello_encoding/src/glyph_cache.rs
Outdated
| engine: skrifa::outline::Engine::AutoFallback, | ||
| target: skrifa::outline::Target::Smooth { | ||
| mode: skrifa::outline::SmoothMode::Lcd, | ||
| // TODO: Set based on whether the anti-aliasing mode is Area? |
There was a problem hiding this comment.
I believe we should always set this to false as you’ve done here. See googlefonts/fontations#1080
vello_encoding/src/glyph_cache.rs
Outdated
| mode: skrifa::outline::SmoothMode::Lcd, | ||
| // TODO: Set based on whether the anti-aliasing mode is Area? | ||
| symmetric_rendering: false, | ||
| // TODO: Does Parley handle layout in a hinting-aware way? |
There was a problem hiding this comment.
Parley expects linear metrics. Hinting aware layout requires scaling glyph outlines to compute hinted advance widths which is incredibly expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main consequence of this is that there is a new auto-hinter.
I've also removed the
glyphmodule from Vello, as the actual code in there is never used, as far as I can see.