Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wgpu-profiler #687

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade wgpu-profiler #687

wants to merge 2 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 12, 2024

This doesn't work on my machine - see Wumpf/wgpu-profiler#82

Fixes #678

@waywardmonkeys
Copy link
Contributor

@DJMcNab This can be changed to 0.18.2 now and should be able to land!

@DJMcNab DJMcNab added this to the Vello 0.3 release milestone Sep 23, 2024
@DJMcNab DJMcNab marked this pull request as ready for review September 23, 2024 10:28
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this doesn't crash anymore on macOS for me ... but now it dies a lot with the negative Duration. But that's how it is on macOS for now...

@DJMcNab
Copy link
Member Author

DJMcNab commented Sep 23, 2024

Dies? It shouldn't crash with a negative duration, it should display the duration as negative, I think?

What's the panic message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpu profiling validation error after debug layers changes
2 participants