Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: with_winit 0-sized canvas on wasm #482

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Bug fix: with_winit 0-sized canvas on wasm #482

merged 2 commits into from
Mar 1, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Mar 1, 2024 •
edited
Loading

Closes #481

image

@simbleau simbleau linked an issue Mar 1, 2024 that may be closed by this pull request
WASM: 0 size canvas for with_winit demo #481
Closed
@simbleau simbleau changed the title fix: 0-sized canvas on wasm Bug fix: with_winit 0-sized canvas on wasm Mar 1, 2024
@simbleau
Copy link
Member Author

simbleau commented Mar 1, 2024

Ready for review.

@simbleau simbleau added this pull request to the merge queue Mar 1, 2024
@simbleau simbleau mentioned this pull request Mar 1, 2024
Merged
4 tasks
Merged via the queue into main with commit 693990f Mar 1, 2024
9 checks passed
@xStrom xStrom deleted the issue-481 branch March 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM: 0 size canvas for with_winit demo
2 participants
@simbleau @nicoburns