Use semicolons more when nothing is returned. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Nov 4, 2023
| } | ||
|
|
||
| fn line_to(&mut self, x: f32, y: f32) { | ||
| self.line_to(x, y) |
There was a problem hiding this comment.
I disagree with the title on principle - something is being returned, it's just the zero-sized unit
But this is better style, thanks! Was this found by automated means? If so, should the rules be committed somehow
|
This is https://rust-lang.github.io/rust-clippy/rust-1.73.0/index.html#/semicolon_if_nothing_returned (hence the commit comment) I'll amend this to enable this lint and see what happens. |
waywardmonkeys
force-pushed
the
more-semicolons-more-more-more
branch
from
8363c62
to
cc30f9e
Compare
|
Updated to enable the lint. It'll be nice when we can configure these in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.