Move WGPU engine to its own module #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disentangle the wgpu implementation of Engine from the mechanisms to create recordings, as the former can in theory be used with multiple back-ends. Also change the name to WgpuEngine to emphasize that it is one choice among possibly many. Most clients are currently using the `Renderer` abstraction, which is not changed, so the refactor is fairly well hidden.
armansito
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
I think this is a good step towards modularization and unblocks other backends/engines.
One thing I would like to see going forward is for the CPU execution logic to be decoupled from the GPU backend-specific engines; I would like to come up with a modular design that allows CPU shaders to interoperate with GPU stages on any backend without having to duplicate concepts like TransientBindMap and TransientBuf for every engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disentangle the wgpu implementation of Engine from the mechanisms to create recordings, as the former can in theory be used with multiple back-ends.
Also change the name to WgpuEngine to emphasize that it is one choice among possibly many. Most clients are currently using the
Rendererabstraction, which is not changed, so the refactor is fairly well hidden.