Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with_bevy: Update to bevy 0.11 release. #343

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

waywardmonkeys
Copy link
Contributor

  • Use add_plugins as add_plugin is deprecated.
  • Use world.resource instead of unwrapping world.get_resource as it gives better error messages.
  • Add the VelloRenderer to the render app in the finish method as the Renderer is async and may not have initialized by the time that the Vello plugin is being set up.

* Use `add_plugins` as `add_plugin` is deprecated.
* Use `world.resource` instead of unwrapping `world.get_resource`
  as it gives better error messages.
* Add the `VelloRenderer` to the render app in the `finish` method
  as the `Renderer` is async and may not have initialized by the
  time that the Vello plugin is being set up.
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, just one thought about being idiomatic

Runs alright on my machine

examples/with_bevy/src/main.rs Show resolved Hide resolved
@waywardmonkeys waywardmonkeys merged commit 6e9b5c0 into linebender:main Jul 20, 2023
@waywardmonkeys waywardmonkeys deleted the update-bevy-example branch July 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants