Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than 256 bins #680

Open
DJMcNab opened this issue Sep 2, 2024 · 0 comments
Open

Support more than 256 bins #680

DJMcNab opened this issue Sep 2, 2024 · 0 comments

Comments

@DJMcNab
Copy link
Member

DJMcNab commented Sep 2, 2024

Currently, if we try and perform a render with more than 256 bins (e.g. a render larger than 4096 by 4096 pixels), we stop rendering below the 256th bin.
I believe that this limit only occurs in binning, as all the algorithms assume there are fewer bins than the workgroup size of that element.

This was debugged following the trail from #548 (comment).
I don't really understand how this issue is occurring in that case, as even full screen on a retina 5k Mac screen, there should still be only 240 bins being rendered. Additionally, the video demonstrating this has in-congruent behaviour with this theory, as the "Try the tutorial" button is still appearing. This suggests that user is experiencing a different issue.

DJMcNab added a commit to DJMcNab/vello that referenced this issue Sep 2, 2024
DJMcNab added a commit to DJMcNab/vello that referenced this issue Sep 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
See #680 for details.

This test will currently pass, but only because the behaviour is
incorrect.

This adds a warning for when this bug would apply, for users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant