Always disable font smoothing when creating a CoreGraphicsContext #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all text rendered match the rendering used by Sketch. There's also this blog post by Tonsky that discusses it.
To me this seems reasonable to just disable for all apps. But could also make changing this a custom option that people can opt-in to? (Although I'd maybe still argue for defaulting to false)
Here are some
@2x
screenshots taken in Pages (which uses font smoothing if it's turned on system-wide) and Sketch (which always turns it off). The font is Mallory MicroPlus BoldI notice the effect a lot more when it's white text on a dark background. Not sure if that's actually a rendering difference or just an optical illusion