Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fontique] use windows-rs for dwrite backend #85

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

dfrg
Copy link
Collaborator

@dfrg dfrg commented Jul 21, 2024

Swaps out winapi, wio and dwrote for windows-core and windows.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have my Windows machine handy, so I can't actually run this, so just going through the patch when DirectWrite isn't my thing, so I have a couple of questions below.

The code looks better overall though!

fontique/src/backend/dwrite.rs Show resolved Hide resolved
fontique/src/backend/dwrite.rs Show resolved Hide resolved
@waywardmonkeys
Copy link
Contributor

@dfrg Any chance this could land soon so that it can be part of our next release?

@waywardmonkeys waywardmonkeys added this to the 0.2 Release milestone Sep 19, 2024
@xorgy
Copy link
Member

xorgy commented Sep 27, 2024

Alright, I'll take a look at this and rebase/merge if it looks good.

@xorgy xorgy force-pushed the dwrite_windows_rs branch 2 times, most recently from 2aa7d7c to 8f4efc0 Compare September 30, 2024 12:01
Swaps out winapi, wio and dwrote for windows-core and windows.
@xorgy xorgy added this pull request to the merge queue Sep 30, 2024
@xorgy xorgy removed this pull request from the merge queue due to a manual request Sep 30, 2024
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with 2 comments (1 of which requires action).

CHANGELOG.md Show resolved Hide resolved
fontique/src/backend/dwrite.rs Show resolved Hide resolved
@xorgy xorgy added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 41821d4 Sep 30, 2024
20 checks passed
@xorgy xorgy deleted the dwrite_windows_rs branch September 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants