parley: fix Cursor::previous_visual by mirroring Cursor::next_visual
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This introduces other problems (see the Zulip thread). |
|
Btw, your link was broken by a topic move. Correct link is now https://xi.zulipchat.com/#narrow/stream/205635-text/topic/Parley.20editor.20example.3A.20wrong.20boundary.20detection.3F |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting upstream from the first cluster after a hard line break and then moving the selection one cluster downstream (to the left in ltr text), the cursor moves to the end of the previous line, instead of to the downstream position of that first cluster. This fixes that by mirroring the implementation of
Cursor::next_visualtoCursor::previous_visual.Zulip thread: https://xi.zulipchat.com/#narrow/stream/296640-font-tech/topic/Parley.20editor.20example.3A.20wrong.20boundary.20detection.3F