Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plist deserialization: investigate better error reporting #196

Open
madig opened this issue Nov 2, 2021 · 4 comments
Open

Plist deserialization: investigate better error reporting #196

madig opened this issue Nov 2, 2021 · 4 comments

Comments

@madig
Copy link
Collaborator

madig commented Nov 2, 2021

I just had someone edit a contents.plist file and forgetting to delete the <value> and the <key>. The returned error was

UnexpectedEventType { expected: ValueOrStartCollection, found: EndCollection }

Not very helpful. norad should take care to bubble up the file in question and ideally the location of the 💥.

@madig madig mentioned this issue Nov 23, 2021
10 tasks
@madig madig added this to the 1.0.0 milestone Nov 23, 2021
@madig
Copy link
Collaborator Author

madig commented Jan 5, 2022

We now have an error chain so at least we know which file blows up. Line information in quick_xml and plist seems harder to come by?

@madig
Copy link
Collaborator Author

madig commented Jan 11, 2022

I don't think we can do something for a v1.0? Eventually we need to take our found plist problems upstream or make a custom plist handler.

@cmyr
Copy link
Member

cmyr commented Jan 15, 2022

I think as long as this is just about how errors are represented/printed it's okay to worry about after 1.0. :)

@madig
Copy link
Collaborator Author

madig commented Jan 17, 2022

I think it is, or at least I hope so. If we implement our own plist parser crate (on top tof quick_xml), we need to change the publicly exposed error types, though. That's a vague "if" though. Taking this off of 1.0 for now, there's no shame in a 2.0 :)

@madig madig removed this from the 1.0.0 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants