Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization: Option to have object libs stay where they are #188

Open
madig opened this issue Sep 29, 2021 · 2 comments
Open

Deserialization: Option to have object libs stay where they are #188

madig opened this issue Sep 29, 2021 · 2 comments

Comments

@madig
Copy link
Collaborator

madig commented Sep 29, 2021

In iondrive, I have to reverse norad's automatic extraction of object libs into .lib fields. It would be easier if I could just pass the data through unchanged.

@madig madig changed the title Option to have object libs stay where they are Deserialization: Option to have object libs stay where they are Oct 4, 2021
@madig
Copy link
Collaborator Author

madig commented Oct 12, 2021

Maybe this can be a DataRequest field.

@cmyr
Copy link
Member

cmyr commented Oct 12, 2021

If it makes more sense to leave these libs in place, then we should do that, but I'm not in favour of making it an option unless there's a really compelling rationale. In my experience this sort of thing just makes the code more complicated and makes using the crate more error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants