Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some of the SVG support in no_std #356

Merged

Conversation

waywardmonkeys
Copy link
Contributor

Some of the SVG functionality builds with no_std and can reasonably be enabled.

@waywardmonkeys
Copy link
Contributor Author

The CI failure is due to the CI here not being Linebender standard and having a fixed stable toolchain and we haven't yet fixed the issues here with unexpected_cfgs and friends.

Will look into that as a separate PR.

@waywardmonkeys
Copy link
Contributor Author

I'll rebase this on top of #358 once that lands so that I can add an appropriate changelog entry here without having it generate a conflict.

Some of the SVG functionality builds with `no_std` and can
reasonably be enabled.
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested both std and no_std

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 3, 2024
Merged via the queue into linebender:main with commit 58c63a0 Aug 3, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the adjust-std-svg-support branch August 3, 2024 12:40
@waywardmonkeys waywardmonkeys added this to the August, 2024 Release milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants