-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the linebender lint set #369
Comments
Hi @PoignardAzur, Could I be assigned to this task? |
@devcollinss No one is currently working on this, so feel free to submit self-contained patches for the various lints. I have some reservations about some of the lints, so if something is a big change, feel free to talk with us about it! Maybe a good structure is a draft PR that has a lot of commits in it so that we can review them separately but still squash it down when it is ready to hit |
@PoignardAzur I just made a draft PR #391 |
We don't need to raise the MSRV to add them to |
We should add a standardized set of rustc lints and clippy lints to all our projects. If we raise MSRV to 1.74, we can add them directly to
Cargo.toml
.See zulip discussion for what our lint set should be. See linebender/peniko#47 for our current lint set.
Aside from the
Cargo.toml
lints, we should also add the following annotation to our crate root:(We don't want a workspace-level lints for those because we want to tolerate prints in tests and examples.)
See this zulip thread for details.
We should add the following annotation at the crate roots:
We should also remove leftover prints, if any, or give them an opt-out.
The text was updated successfully, but these errors were encountered: