Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-unknown-features to the CI. #27

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Nov 1, 2024

Having this flag enables the CI to continue working if the workspace gets a package that doesn't have e.g. the std feature.

This brings it in sync with the latest Linebender standard, see e.g. parley.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To clarify for future readers, this only applies to the features explicitly added.
There is a small risk that a package's std or libm feature is misnamed, but I think that's sufficiently unlikely as to be ignored.

@xStrom xStrom added this pull request to the merge queue Nov 1, 2024
Merged via the queue into linebender:main with commit c1df926 Nov 1, 2024
15 checks passed
@xStrom xStrom deleted the syncci branch November 1, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants