Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example and new convenience methods for druid menus #2260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Example and new convenience methods for druid menus #2260

wants to merge 3 commits into from

Conversation

xarvic
Copy link
Collaborator

@xarvic xarvic commented Sep 20, 2022

No description provided.

@xStrom
Copy link
Member

xStrom commented Jan 12, 2023

Please rebase on master so we can pass the CI.

Also, what is going on here? Please provide at least a short paragraph describing what the changes are supposed to be doing.

@xStrom xStrom added the S-waiting-on-author waits for changes from the submitter label Jan 12, 2023
@xarvic
Copy link
Collaborator Author

xarvic commented Jan 21, 2023

This PR introduces helper methods for working with selectable menu items. Menuitem::togle_data() turns a menu item with data of bool into a simple checkbox.
MenuItem::radio_item() makes the menu item selectable. It is selected if the data is equal to the provided value.

@xarvic xarvic added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-review waits for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xarvic @xStrom