Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitStream not working in one of repository in our organization, but it works in my personal repository. #188

Open
Sekhar9581 opened this issue May 25, 2023 · 11 comments
Labels
bug Something isn't working 👀.

Comments

@Sekhar9581
Copy link

Describe the bug
First, I have tried GITStream with few automation actions in my personal GitHub repository, it worked fine. But same not working in one of repository of our organization. I have installed GITStream in a repository and added gitstream.cm and gitstream.yml file properly, still I cannot see any action running. Tried with different automations, nothing works. Do I need to focus on any organization/repository settings?
A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. The .cm automation file
  2. The PR URL (as it contains the repo and PR identifiers)
  3. Describe your PR relevant content
  4. Add relevant commit SHA

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots
gitstream

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@Sekhar9581 Sekhar9581 added the bug Something isn't working label May 25, 2023
@vim-zz
Copy link
Collaborator

vim-zz commented May 25, 2023

@Sekhar9581 Thank you for giving gitStream a try!

Check the following:

Go to https://github.com/apps/gitstream-cm/installations/new and check that under Repository access you selected either All or the repositories you want gitStream to work in.

Check you see the following directory strcuture in your repo:

.
├─ .cm/
│  └─ gitstream.cm
├─ .github/
│  └─ workflows/
│     └─ gitstream.yml

If these steps doesn't help, please check the Action tab, and see if it includes gitStream runs.

Let me know if it worked

@Sekhar9581
Copy link
Author

Thanks for responding. Verified that I have selected only one repository for access and I can see gitStream under Settings>Github Apps and gitstream.cm and gitstream.yml are placed in proper directory. I cannot see any workflows in Actions tab.
gitstream
gitstream

@vim-zz
Copy link
Collaborator

vim-zz commented May 25, 2023

Does both files merged to the default branch?

.
├─ .cm/
│  └─ gitstream.cm
├─ .github/
│  └─ workflows/
│     └─ gitstream.yml

@Sekhar9581
Copy link
Author

Yes. I have main(default) and test branches, both are having the cm and yml files. Im making changes in test branch and trying to merge into main through pull request. I cannot see gitstream running as shown in below snap
gitstream

@vim-zz
Copy link
Collaborator

vim-zz commented May 25, 2023

It seems that gitStream service isn't triggered by GitHub on your pull request, therefore it doesn't run the GitHub action at all. Can you share the org name you installed gitStream for (it's the 2nd element in the PR URL, right after https://github.com)? It will help to make sure that it was installed properly

@Sekhar9581
Copy link
Author

Sure, here it is 'https://github.com/Ocwen-Financial/gitstream'

@vim-zz
Copy link
Collaborator

vim-zz commented May 28, 2023

@Sekhar9581
Copy link
Author

Hi @vim-zz took some time to get back to you. Before enabling IP allow list for installed GitHub Apps, I have some queries. Can you please help me to understand below?

  1. How do I check the IP address of gitstream before enabling IP allow list?
  2. We are in a restricted environment and only allowed internal IPs for access. Is it safe to allow gitstream IP in our environment?
  3. Will gitstream expose my code to the outside world? If yes, what level of code will be exposed externally?

@vim-zz
Copy link
Collaborator

vim-zz commented Jun 19, 2023

Hi @Sekhar9581

  1. Since gitStream is a GitHub app, you can automatically add to your allow list the IP addresses configured for GitHub apps that you install in your organization learn more here
  2. In this configuration, you allow to use gitStream app IP only to react on events that originated from GitHub while not allowing any other traffic from the IP of gitStream app
  3. gitStream doesn’t extract your source code. Like any other CI/CD automation, the source code is being scanned in the repo using your CI runners and is not shared with any external services

I hope it clarify things, let me know if you have more questions

@Sekhar9581
Copy link
Author

Sekhar9581 commented Jun 28, 2023

Hi @vim-zz
Thanks for clarifying our queries. We have enabled IP allow list for installed GitHub Apps in our Organization. After enable IP allow list, I created new pull request. gitStream ran in the background while I was creating the pull request, but after sometime it showed as checks skipped. I have attached the screenshot. Please let me know if I missed anything.
Thanks.
gitStream

@BenLloydPearson
Copy link
Collaborator

Hi @Sekhar9581 thanks for your patience with us.

Are you still having this issue? If so, do you see any errors in your GitHub Actions log for this?

@vim-zz vim-zz added the 👀. label Dec 28, 2023
@vim-zz vim-zz changed the title GITStream not working in one of repository in our organization, but it works in my personal repository. gitStream not working in one of repository in our organization, but it works in my personal repository. Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀.
Projects
None yet
Development

No branches or pull requests

3 participants