-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1974: Fix cannot jump to reply #1995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
hieutbui,
tddang-linagora and
Te-Z
as code owners
August 13, 2024 04:30
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1995 |
sherlockvn
reviewed
Aug 14, 2024
sherlockvn
approved these changes
Aug 23, 2024
Tested on Android and Chrome. It works well most of the time, but sometimes it stops working, and you need to re-enter the chat for it to function normally DemoscrollToMessage.webm2024-08-26.12-51-28.mp4 |
nqhhdev
force-pushed
the
TW-1974-fix-cannot-jump-to-reply
branch
from
August 30, 2024 02:38
650592b
to
0d48de4
Compare
i tested in web, and it works well for me |
hoangdat
reviewed
Sep 4, 2024
hoangdat
reviewed
Sep 4, 2024
hi @KhaledNjim, can you test again. |
Tested again, works well for me |
KhaledNjim
approved these changes
Sep 4, 2024
please rebase @nqhhdev |
nqhhdev
force-pushed
the
TW-1974-fix-cannot-jump-to-reply
branch
from
September 4, 2024 09:00
6619426
to
5c212d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolved
For load more:
Updated the highlight message when click to reply message
Remove old logic (
requestHistory
) of listen scroll in chatWeb:
Screen.Recording.2024-08-13.at.11.40.18.mov
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-13.at.11.24.15.mp4