Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1974: Fix cannot jump to reply #1995

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Aug 13, 2024

Ticket

Resolved

  • For load more:

    • I updated logic to load more in chat. When user scrolls to the last element of the list message, we're display a refresh icon and call back to request history.
  • Updated the highlight message when click to reply message

  • Remove old logic ( requestHistory ) of listen scroll in chat

  • Web:

Screen.Recording.2024-08-13.at.11.40.18.mov
  • IOS:
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-13.at.11.24.15.mp4

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1995

@KhaledNjim
Copy link
Contributor

Tested on Android and Chrome. It works well most of the time, but sometimes it stops working, and you need to re-enter the chat for it to function normally

Demo

scrollToMessage.webm
2024-08-26.12-51-28.mp4

@sherlockvn
Copy link
Contributor

i tested in web, and it works well for me

lib/pages/chat/chat.dart Outdated Show resolved Hide resolved
@hoangdat
Copy link
Member

hoangdat commented Sep 4, 2024

hi @KhaledNjim, can you test again.

@KhaledNjim
Copy link
Contributor

Tested again, works well for me

@hoangdat
Copy link
Member

hoangdat commented Sep 4, 2024

please rebase @nqhhdev

@hoangdat hoangdat merged commit ef051c4 into main Sep 4, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1974-fix-cannot-jump-to-reply branch September 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants