Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limactl: make sure to remove "." from instance names #2815

Closed
wants to merge 1 commit into from
Closed

limactl: make sure to remove "." from instance names #2815

wants to merge 1 commit into from

Conversation

AkihiroSuda
Copy link
Member

Now limactl create template://ubuntu-24.10 creates ubuntu-24-10.

Fix #2813

@AkihiroSuda
limactl: make sure to remove "." from instance names
7f7f3db 
Now `limactl create template://ubuntu-24.10` creates `ubuntu-24-10`.

Fix issue 2813

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 28, 2024
@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Oct 28, 2024
jandubois
jandubois requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now limactl create template://ubuntu-24.10 creates ubuntu-24-10

I disagree with this. I think we should rename the template to ubuntu-24-10.yaml instead.

@jandubois
Copy link
Member

I disagree with this. I think we should rename the template to ubuntu-24-10.yaml instead.

Alternatively, we could call the instance ubuntu-24.10 but the hostname inside the VM lima-ubuntu-24-10 since we modify the instance name to get the hostname anyways.

I still have a slight preference to rename the template though, to keep all the names in sync.

@jandubois jandubois mentioned this pull request Oct 28, 2024
Closed
@AkihiroSuda AkihiroSuda mentioned this pull request Oct 28, 2024
Merged
@AkihiroSuda
Copy link
Member Author

Alternatively, we could call the instance ubuntu-24.10 but the hostname inside the VM lima-ubuntu-24-10 since we modify the instance name to get the hostname anyways.

👍

@AkihiroSuda AkihiroSuda removed this from the v1.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois requested changes

Assignees
No one assigned
Labels
area/cli limactl CLI user experience
Projects
None yet
Milestone
No milestone
2 participants
@AkihiroSuda @jandubois