-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use VZ by default for new instances on macOS >= 13.5 #1951
Conversation
@lima-vm/maintainers I'll release v1.0 beta after merging this. |
596fd14
to
ed39486
Compare
Here is the logs
|
|
Thanks @hasan4791 , so, is it working as expected? |
Yes. |
a5f6936
to
e1a34f8
Compare
While this only flips what's the default, @AkihiroSuda can we first solve #1940? |
Being fixed in: |
e1a34f8
to
e71d148
Compare
Split trivial parts into: |
467ad87
to
ed49091
Compare
Might also be worth waiting for #1957 to be mitigated or resolved |
I think that is the plan to delay the 1.0 release until VZ can safely become the default. Unfortunately this has become even more complex with QEMU seemingly broken on Apple M3 chips #1996. So people with a brand new machine currently have no choice than to switch to VZ. |
Just to clarify that despite the title (which I now changed) this was not specific to vz, and we also got corruption with qemu |
@lima-vm/maintainers Are we in a good state to merge this? (after rebasing) |
Finch is going to switch the default to vz soon |
Podman Machine VM changed from qemu to vz (through their own vfkit wrapper), in 5.0: https://blog.podman.io/2024/03/podman-5-0-is-around-the-corner/ (v5.0.0 tagged Mar 19) |
Rebased. @lima-vm/maintainers PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, but I have some feedback. Please check first if there is anything that you agree should be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
I would prefer to remove the one confusing comment line, but am also fine with merging as-is.
examples/experimental/vz.yaml is retained until v1.0 RC, to avoid breaking existing bookmarks. Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
VZ is now the default type for new instances >= 13.5, unless the config is incompatible with vz (e.g., `firmware.legacyBIOS=true`, `mountType=9p`). Existing instances will continue to use QEMU by default, unless `vz-identifier` is present in the instance directory. Run `limactl start` with `--debug` to see how the vmType is resolved. Signed-off-by: Akihiro Suda <[email protected]>
4648e1f
to
df05b81
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@AkihiroSuda I see that "test / vz (fedora.yaml)" keeps getting skipped, and I seem to be unable to re-run it without re-running all tests. Let me know if you want to get it to pass, or merge as-is! |
Merging, CI is green |
VZ is now the default type for new instances >= 13.5, unless the config is incompatible with vz (e.g.,
firmware.legacyBIOS=true
,mountType=9p
).Existing instances will continue to use QEMU by default, unless
vz-identifier
is present in the instance directory.Run
limactl start
with--debug
to see how the vmType is resolved.