Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema should have tests #2768

Closed
AkihiroSuda opened this issue Oct 19, 2024 · 1 comment · Fixed by #2769
Closed

jsonschema should have tests #2768

AkihiroSuda opened this issue Oct 19, 2024 · 1 comment · Fixed by #2769
Labels
area/test Tests and CI

Comments

@AkihiroSuda
Copy link
Member

Can we have a test? What happens when this is out of the sync with the YAML struct definition?

Originally posted by @AkihiroSuda in #2306 (comment)
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Oct 19, 2024
@afbjorklund afbjorklund mentioned this issue Oct 20, 2024
Merged
@afbjorklund
Copy link
Member

Now the generation of the schema will fail, if the result doesn't match the default yaml

e.g.

- at '/mountTypesUnsupported': got null, want array

(if removing the "nullable", like when it was added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test Tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate the jsonschema against default.yaml afbjorklund/lima
2 participants
@AkihiroSuda @afbjorklund