From df05b810183ce999e36933f0dba7c25fa20245c3 Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Thu, 26 Oct 2023 20:42:58 +0900 Subject: [PATCH] Use VZ by default for new instances on macOS >= 13.5 VZ is now the default type for new instances >= 13.5, unless the config is incompatible with vz (e.g., `firmware.legacyBIOS=true`, `mountType=9p`). Existing instances will continue to use QEMU by default, unless `vz-identifier` is present in the instance directory. Run `limactl start` with `--debug` to see how the vmType is resolved. Signed-off-by: Akihiro Suda --- .github/workflows/test.yml | 6 +- examples/default.yaml | 2 +- pkg/limayaml/defaults.go | 95 ++++++++++++++++++- pkg/limayaml/defaults_test.go | 9 +- .../content/en/docs/config/vmtype/_index.md | 5 +- 5 files changed, 107 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index eea519bf499..533ba8dabd1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -148,6 +148,7 @@ jobs: integration: name: Integration tests + # on macOS 12, the default vmType is QEMU runs-on: macos-12 timeout-minutes: 120 steps: @@ -405,13 +406,14 @@ jobs: vz: name: "vz" + # on macOS 13, the default vmType is VZ runs-on: macos-13 timeout-minutes: 120 strategy: fail-fast: false matrix: template: - - experimental/vz.yaml + - default.yaml - fedora.yaml steps: - uses: actions/checkout@v4 @@ -438,8 +440,6 @@ jobs: - name: Uninstall qemu run: brew uninstall --ignore-dependencies --force qemu - name: Test - env: - LIMACTL_CREATE_ARGS: "--vm-type vz --mount-type virtiofs --rosetta --network vzNAT" run: ./hack/test-templates.sh templates/${{ matrix.template }} - if: failure() uses: ./.github/actions/upload_failure_logs_if_exists diff --git a/examples/default.yaml b/examples/default.yaml index 0ec0f7c9db6..4df6395689a 100644 --- a/examples/default.yaml +++ b/examples/default.yaml @@ -8,7 +8,7 @@ # VM type: "qemu", "vz" (on macOS 13 and later), or "default". # The vmType can be specified only on creating the instance. # The vmType of existing instances cannot be changed. -# 🟢 Builtin default: "qemu" +# 🟢 Builtin default: "vz" (on macOS 13.5 and later), "qemu" (on others) vmType: null # OS: "Linux". diff --git a/pkg/limayaml/defaults.go b/pkg/limayaml/defaults.go index f69a320f9ba..160cb9787ca 100644 --- a/pkg/limayaml/defaults.go +++ b/pkg/limayaml/defaults.go @@ -3,6 +3,7 @@ package limayaml import ( "bytes" "crypto/sha256" + "errors" "fmt" "net" "os" @@ -13,6 +14,7 @@ import ( "strings" "text/template" + "github.com/coreos/go-semver/semver" "github.com/docker/go-units" "github.com/pbnjay/memory" "github.com/sirupsen/logrus" @@ -178,7 +180,7 @@ func FillDefault(y, d, o *LimaYAML, filePath string) { if o.VMType != nil { y.VMType = o.VMType } - y.VMType = ptr.Of(ResolveVMType(y.VMType)) + y.VMType = ptr.Of(ResolveVMType(y, d, o, filePath)) if y.OS == nil { y.OS = d.OS } @@ -924,11 +926,96 @@ func NewVMType(driver string) VMType { } } -func ResolveVMType(s *string) VMType { - if s == nil || *s == "" || *s == "default" { +func isExistingInstanceDir(dir string) bool { + // existence of "lima.yaml" does not signify existence of the instance, + // because the file is created during the initialization of the instance. + for _, f := range []string{ + filenames.HostAgentStdoutLog, filenames.HostAgentStderrLog, + filenames.VzIdentifier, filenames.BaseDisk, filenames.DiffDisk, filenames.CIDataISO, + } { + file := filepath.Join(dir, f) + if _, err := os.Lstat(file); !errors.Is(err, os.ErrNotExist) { + return true + } + } + return false +} + +func ResolveVMType(y, d, o *LimaYAML, filePath string) VMType { + // Check if the VMType is explicitly specified + for i, f := range []*LimaYAML{o, y, d} { + if f.VMType != nil && *f.VMType != "" && *f.VMType != "default" { + logrus.Debugf("ResolveVMType: resolved VMType %q (explicitly specified in []*LimaYAML{o,y,d}[%d])", *f.VMType, i) + return NewVMType(*f.VMType) + } + } + + // If this is an existing instance, guess the VMType from the contents of the instance directory. + if dir, basename := filepath.Split(filePath); dir != "" && basename == filenames.LimaYAML && isExistingInstanceDir(dir) { + vzIdentifier := filepath.Join(dir, filenames.VzIdentifier) // since Lima v0.14 + if _, err := os.Lstat(vzIdentifier); !errors.Is(err, os.ErrNotExist) { + logrus.Debugf("ResolveVMType: resolved VMType %q (existing instance, with %q)", VZ, vzIdentifier) + return VZ + } + logrus.Debugf("ResolveVMType: resolved VMType %q (existing instance, without %q)", QEMU, vzIdentifier) + return QEMU + } + + // Resolve the best type, depending on GOOS + switch runtime.GOOS { + case "darwin": + macOSProductVersion, err := osutil.ProductVersion() + if err != nil { + logrus.WithError(err).Warn("Failed to get macOS product version") + logrus.Debugf("ResolveVMType: resolved VMType %q (default for unknown version of macOS)", QEMU) + return QEMU + } + // Virtualization.framework in macOS prior to 13.5 could not boot Linux kernel v6.2 on Intel + // https://github.com/lima-vm/lima/issues/1577 + if macOSProductVersion.LessThan(*semver.New("13.5.0")) { + logrus.Debugf("ResolveVMType: resolved VMType %q (default for macOS prior to 13.5)", QEMU) + return QEMU + } + // Use QEMU if the config depends on QEMU + for i, f := range []*LimaYAML{o, y, d} { + if f.Arch != nil && !IsNativeArch(*f.Arch) { + logrus.Debugf("ResolveVMType: resolved VMType %q (non-native arch=%q is specified in []*LimaYAML{o,y,d}[%d])", QEMU, *f.Arch, i) + return QEMU + } + if f.Firmware.LegacyBIOS != nil && *f.Firmware.LegacyBIOS { + logrus.Debugf("ResolveVMType: resolved VMType %q (firmware.legacyBIOS is specified in []*LimaYAML{o,y,d}[%d])", QEMU, i) + return QEMU + } + if f.MountType != nil && *f.MountType == NINEP { + logrus.Debugf("ResolveVMType: resolved VMType %q (mountType=%q is specified in []*LimaYAML{o,y,d}[%d])", QEMU, NINEP, i) + return QEMU + } + if f.Audio.Device != nil { + switch *f.Audio.Device { + case "", "none", "default", "vz": + // NOP + default: + logrus.Debugf("ResolveVMType: resolved VMType %q (audio.device=%q is specified in []*LimaYAML{o,y,d}[%d])", QEMU, *f.Audio.Device, i) + return QEMU + } + } + if f.Video.Display != nil { + switch *f.Video.Display { + case "", "none", "default", "vz": + // NOP + default: + logrus.Debugf("ResolveVMType: resolved VMType %q (video.display=%q is specified in []*LimaYAML{o,y,d}[%d])", QEMU, *f.Video.Display, i) + return QEMU + } + } + } + // Use VZ if the config is compatible with VZ + logrus.Debugf("ResolveVMType: resolved VMType %q (default for macOS 13.5 and later)", VZ) + return VZ + default: + logrus.Debugf("ResolveVMType: resolved VMType %q (default for GOOS=%q)", QEMU, runtime.GOOS) return QEMU } - return NewVMType(*s) } func ResolveOS(s *string) OS { diff --git a/pkg/limayaml/defaults_test.go b/pkg/limayaml/defaults_test.go index c09fcdbd9c3..9c4ffd9f88b 100644 --- a/pkg/limayaml/defaults_test.go +++ b/pkg/limayaml/defaults_test.go @@ -14,12 +14,16 @@ import ( "github.com/lima-vm/lima/pkg/ptr" "github.com/lima-vm/lima/pkg/store/dirnames" "github.com/lima-vm/lima/pkg/store/filenames" + "github.com/sirupsen/logrus" "gotest.tools/v3/assert" ) func TestFillDefault(t *testing.T) { + logrus.SetLevel(logrus.DebugLevel) var d, y, o LimaYAML + defaultVMType := ResolveVMType(&y, &d, &o, "") + opts := []cmp.Option{ // Consider nil slices and empty slices to be identical cmpopts.EquateEmpty(), @@ -59,7 +63,7 @@ func TestFillDefault(t *testing.T) { // Builtin default values builtin := LimaYAML{ - VMType: ptr.Of("qemu"), + VMType: &defaultVMType, OS: ptr.Of(LINUX), Arch: ptr.Of(arch), CPUType: defaultCPUType(), @@ -192,6 +196,7 @@ func TestFillDefault(t *testing.T) { } expect := builtin + expect.VMType = ptr.Of(QEMU) // due to NINEP expect.HostResolver.Hosts = map[string]string{ "MY.Host": "host.lima.internal", } @@ -472,6 +477,8 @@ func TestFillDefault(t *testing.T) { expect.Param["TWO"] = d.Param["TWO"] + t.Logf("d.vmType=%q, y.vmType=%q, expect.vmType=%q", *d.VMType, *y.VMType, *expect.VMType) + FillDefault(&y, &d, &LimaYAML{}, filePath) assert.DeepEqual(t, &y, &expect, opts...) diff --git a/website/content/en/docs/config/vmtype/_index.md b/website/content/en/docs/config/vmtype/_index.md index 73978be06da..25ef8d4ad4e 100644 --- a/website/content/en/docs/config/vmtype/_index.md +++ b/website/content/en/docs/config/vmtype/_index.md @@ -22,9 +22,12 @@ flowchart intel_on_arm -- "No" --> vz["VZ"] ``` +The default vmType is QEMU in Lima prior to v1.0. +Starting with Lima v1.0, Lima will use VZ by default on macOS (>= 13.5) for new instances, +unless the config is incompatible with VZ. (e.g., legacyBIOS or 9p is enabled) + ## QEMU "qemu" option makes use of QEMU to run guest operating system. -This option is used by default if "vmType" is not set. ## VZ > **Warning**