Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix.dom/tags removed #152

Closed
rschmukler opened this issue Dec 7, 2023 · 2 comments
Closed

helix.dom/tags removed #152

rschmukler opened this issue Dec 7, 2023 · 2 comments

Comments

@rschmukler
Copy link

rschmukler commented Dec 7, 2023

Hey! Seems like the style indent PR commented out helix.dom/tags. This caused my defc wrapper macro to break as I was relying on it.

Is this something that was intentional or are you open to re-adding it to help maintain API stability? Otherwise I could also just use ns-externs but ironically, the gen-tag macro still remains

@lilactown
Copy link
Owner

@rschmukler I didn't think that anyone would rely on the helix.dom/tags var. What exactly are you using it for?

I'm tempted to clean up the gen-tag function and the rest of the code. You could use ns-externs, but you'll also have to filter out $d

@rschmukler
Copy link
Author

rschmukler commented Dec 7, 2023

I prefer hiccup to the macros so I am building a mappings of keywords to helix.dom macros in my own defc wrapper. Eg. :h1 resolves to helix.dom/h1 by the time the macro is done expanding.

I was doing that by iterating the tags, but using ns-externs works just as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants