From a681f8fa98824ab69b06aa71c50ee2c8dd349270 Mon Sep 17 00:00:00 2001 From: Isaac Bowen Date: Mon, 3 Jul 2023 15:51:57 -0500 Subject: [PATCH] loosen our engine version specs, to allow the same major version (#256) https://usemechanic.slack.com/archives/CURE65U2W/p1688354837252619 --- .github/workflows/test.yml | 5 ++++- package-lock.json | 4 ++-- package.json | 4 ++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 54c25938..ab16eabe 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,10 @@ jobs: steps: - uses: actions/checkout@v3 - name: Install node and npm - uses: lightward/setup-node-npm@v4 + uses: actions/setup-node@v3 + with: + node-version: 18 + check-latest: true - name: Install node packages run: npm ci - name: Run tests diff --git a/package-lock.json b/package-lock.json index 0001c324..23348a5e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,8 +16,8 @@ "sort-json": "2.0.1" }, "engines": { - "node": "18.16.1", - "npm": "9.7.2" + "node": ">=18 <19", + "npm": ">=9 <10" } }, "node_modules/@pkgjs/parseargs": { diff --git a/package.json b/package.json index 2d4c3bff..d594e4d5 100644 --- a/package.json +++ b/package.json @@ -4,8 +4,8 @@ "repository": "git@github.com:lightward/mechanic-tasks.git", "homepage": "https://tasks.mechanic.dev/", "engines": { - "node": "18.16.1", - "npm": "9.7.2" + "node": ">=18 <19", + "npm": ">=9 <10" }, "dependencies": { "@shopify/prettier-config": "1.1.2",