tapgarden/[bug]: batch not marked as confirmed before universe proof delivery

[jharveyb]

Once a batch reaches state BatchStateConfirmed, the minter has created and stored valid minting proofs.

This is done here:

taproot-assets/tapgarden/caretaker.go

Line 1145 in 8fcd27c

err = b.cfg.Log.MarkBatchConfirmed(

That call happens after the caretaker tries to deliver genesis proofs to a configured Universe.

taproot-assets/tapgarden/caretaker.go

Line 1135 in 8fcd27c

if b.cfg.Universe != nil {

This means that if the upload to a Universe fails, the batch will not reach the proper state on disk. This may also cause issues on restart if genesis proofs were not delivered before shutdown, or if the Universe was misconfigured at the time of minting.

Related to #1009 , could likely be fixed by changes similar to #1074 .

Specifically, we can add a bool to the DB state for each batch to mark if proofs were delivered, and handle proof delivery on retry.