-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[custom channels]: fix bandwidth reported by TLV traffic shaper #1060
Comments
My VERY ROUGH guess is that the |
Thanks for the detailed report. The first part is a known issue: #888 The second time it failed with the temporary channel failure looks odd. Can you attach the logs of both the sending node and the first hop please? |
Going to transfer the issue to the |
We were able to reproduce this issue. This time it's on testnet. I'm attempting to keysend an asset. Let's start with the current state of the channel:
You can see that I have So here is my command, trying to keysend some to my channel counterparty:
The LND logs immediately go beserk. I am attaching the logs here. |
logs from the asset channel originator side. |
Thanks a lot for the logs! Basically due to the channel reserve, the channel can only send a maximum of Which can be seen by this message:
The issue is that the channel is still attempted, because the TLV traffic shaper reports more than enough bandwidth initially:
The So there are two issues here that need fixing:
This will require changes in |
Removing from Sprint 30 |
Probably also need to report Example for paying a 500 sat invoice with assets, but the pathfinding choosing arbitrary (non-TAP channel) first hops:
|
Will dis-aggregate this issue into two sub issues.
|
@GeorgeTsagk was able to reproduce the issue |
Here is the situation.
A node opened an asset channel to my node, and used the
keysend
command to send my node assets.Following the
keysend
, the channel looked like this:You can see the asset balances:
Next: I attempted to
keysend
some assets back to this node. I used the command:The keysend failed with
FAILURE_REASON_INSUFFICIENT_BALANCE
.Following this, my partner node sent me 1000 satoshis, via standard bolt 11 invoice.
Following this, my local sats balance in the channel increased from
500
to1500
satoshisFollowing this, I again attempted the same
keysend
operation. I got a different output, but it was still not successful.The console continued like this with thousands of 'TEMPORARY_CHANNEL_FAILURE @ 0th hop` outputs per second.
NOTE -- this is on Mainnet. Neither my node, nor my partner's node, has a price oracle set up.
The text was updated successfully, but these errors were encountered: