-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only attempt to rustfmt
files checked into git
#3327
Only attempt to rustfmt
files checked into git
#3327
Conversation
This avoids `rustfmt` failing on Rust files generated by dependent crates in `target`, eg ``` + rustfmt --edition 2021 --check ./target/debug/build/thiserror-8230374e07b5c05a/out/probe.rs Diff in /home/matt/rust-lightning-3/target/debug/build/thiserror-8230374e07b5c05a/out/probe.rs at line 1: - #![feature(provide_any)] +#![feature(provide_any)] - use std::any::{Demand, Provider}; +use std::any::{Demand, Provider}; - fn _f<'a, P: Provider>(p: &'a P, demand: &mut Demand<'a>) { - p.provide(demand); - } +fn _f<'a, P: Provider>(p: &'a P, demand: &mut Demand<'a>) { + p.provide(demand); +} ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
- Coverage 89.64% 89.64% -0.01%
==========================================
Files 126 126
Lines 102676 102676
Branches 102676 102676
==========================================
- Hits 92043 92040 -3
- Misses 7909 7912 +3
Partials 2724 2724 ☔ View full report in Codecov by Sentry. |
Probably something is breaking
|
Yes, linting will be broken until #3301 (due to rustc upgrade) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but also looking forward to be able to just drop all of this and start using cargo fmt
soon :)
This avoids
rustfmt
failing on Rust files generated by dependent crates intarget
, eg