-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfmt
: Run on util/*
(2/2)
#3323
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3323 +/- ##
========================================
Coverage 89.59% 89.60%
========================================
Files 126 126
Lines 102676 103419 +743
Branches 102676 103419 +743
========================================
+ Hits 91995 92668 +673
- Misses 7947 7984 +37
- Partials 2734 2767 +33 ☔ View full report in Codecov by Sentry. |
6c4dd83
to
9b991df
Compare
Ugh, can we split this? 42 commits in one PR is just a lot... |
Alright, happy to if you prefer (although at least half of these commits are one-line diffs). Now split out ~the first half of commits to #3324. |
9b991df
to
60ae0af
Compare
.. we pull out `Mutex` field initialization into dedicated variables as they might otherwise land on the same line when formatting, which might lead to lockorder violation false-positives when compiled with the `backtrace` feature.
60ae0af
to
e2dcdc7
Compare
Rebased after #3327 landed. |
This is PR 2/2, based on #3324.
The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).
FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.