Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fallible per commitment point for RAA #3150

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Handle fallible per commitment point for RAA #3150

merged 6 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. Split HolderCommitmentPoint::advance off into separate function

    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    516e5e6 View commit details
    Browse the repository at this point in the history

  2. Return an error if we fail to advance our commitment number

    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9c2a050 View commit details
    Browse the repository at this point in the history

  3. Add logger as parameter in creating ChannelContext

    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1fa67d9 View commit details
    Browse the repository at this point in the history

  4. Change get_per_commitment_point to return result type 

    Includes simple changes to test util signers and tests, as well as
handling the error case for get_per_commitment_point in
HolderCommitmentPoint. This leaves a couple `.expect`s in places
that will be addressed in a separate PR for handling funding.
    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1f7f3a3 View commit details
    Browse the repository at this point in the history

  5. Allow failing revoke_and_ack if commitment point is not available

    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    614da40 View commit details
    Browse the repository at this point in the history

  6. Test async get per commitment point for revoke_and_ack 

    Note: this does not test the CS -> RAA resend ordering, because this
requires handling async get_per_commitment_point for channel
reestablishment, which will be addressed in a follow up PR.
    @alecchendev
    alecchendev committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    45c0a0f View commit details
    Browse the repository at this point in the history